Simplify code loading, bump minor version #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can still support the macro? Otherwise we will have to go through all the packages again with another breaking change. If we keep the macro, this would also allow us to easily test if this new approach works with ClimaAtmos or as unexpected problems. |
Sbozzolo
reviewed
May 30, 2024
|
For the buildkite failure, just bump climacommon |
|
Actually, maybe you already fixed the issue with incompatibility with |
charleskawczynski
force-pushed
the
ck/simplify_code_loading
branch
from
756f5d5
to
e0f1d13
Compare
|
Let's see if #79 can work instead. |
|
Superseded by #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies code loading, and bumps the minor version for a new breaking release.